Feature/map#222
Conversation
|
@tracyfraley1 Here's the work @thill02 did for the mapping. Will is going to take a look. Then see if we can get it merged in. |
|
any status update on this? |
* try updated checkout action * add repository to package.json?
try and get the npm logs
Remove debug step
* Run at /groundwork locally to better emulate docs site * Modify docs template to make home button and breadcrumbs work better. Remove any logic from breadcrumb items, just use the href provided. * Add a `homeUrl` prop to the site wrapper that drives the href of the usace logo in the header, just pass that href down, or if not provided bail with a `#` * add `homeUrl` prop to SiteWrapper docs
|
@krowvin I think this is good to go now, can you review |
There was a problem hiding this comment.
Forgive me, i'll try not to find something new each time!
Extra notes:
-
When I installed the docs they went from 634 kB to 1,130 kB almost doubling. Do we want to make them lazy load so we aren't loading the mapping stuff one every groundwork page?
-
Not certain on if leftToolbar is a component already?
No problem. I'm looking at your proposed changes above right now, but in response to 1 above, I think it's worth taking a look at, i don't think i'd delay this pr for it though |
Agreed |
|
Ok, I think I've resolved everything now |
Note that it is leftSidebar and the other overlays are ...Toolbar
3 participants
No description provided.